Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give Cylc Lint it's own chunk of changelog #6149

Closed
wants to merge 1 commit into from
Closed

Give Cylc Lint it's own chunk of changelog #6149

wants to merge 1 commit into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 17, 2024

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim added this to the 8.3.0 milestone Jun 17, 2024
@wxtim wxtim requested a review from MetRonnie June 17, 2024 14:20
@wxtim wxtim self-assigned this Jun 17, 2024
@oliver-sanders
Copy link
Member

I'm not sure why we would treat cylc lint differently to any other Cylc CLI tool?

@wxtim
Copy link
Member Author

wxtim commented Jun 17, 2024

I'm not sure why we would treat cylc lint differently to any other Cylc CLI tool?

Because it reflects a style guide rather than functional guide. Not to bothered. Close if you don't want it.

@oliver-sanders
Copy link
Member

There are other tools which are "non-functional" too. I don't think we need a top-level section for cylc lint.

@MetRonnie
Copy link
Member

I'm with Oliver on this, voting to close

@MetRonnie MetRonnie closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie Awaiting requested review from MetRonnie

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @oliver-sanders @MetRonnie